Anyway, this is an error that distorts the program's execution logic. Which constant was meant to be checked? Or maybe the second check shouldn't be there at all? These are the questions that only the authors can answer. One of them was probably meant to check some other constant of the HitResult enumeration: public enum HitResult This is a fine example of copy-paste oriented programming, which is a humorous term recently used by my coworker Valeriy Komarov in his article ' Top 10 Bugs Found in Java Projects in 2019'.Īnyway, two identical checks are executed in a row. & (result = HitResult.Perfect || result = HitResult.Perfect)) DrawableHoldNote.cs 266 protected override void CheckForResult(.) V3001 There are identical sub-expressions 'result = HitResult.Perfect' to the left and to the right of the '||' operator. The check did reveal a few interesting bugs, which I'm willing to show you. Leaving out the test files, I checked 1507 files 110 thousand LOC long. The project is small indeed: for instance, the C# core of PVS-Studio is about 300 thousand LOC long.

This number also includes tests, which I usually don't take into account when running checks. cs files with the total of 135 thousand non-empty LOC. One thing that immediately catches your eye is the large number of repository commits (over 24 thousand), which is a sign of intense, ongoing development (the game was first released in 2007, but the work must have begun even earlier). I'm more interested in the project's source code, which is available on GitHub. There's no point in further elaborating on the game you can read all about it on the Internet. The project features free gameplay, colorful design, map customization, an advanced online player ranking system, multiplayer mode, and a rich set of musical pieces. According to the game's website, it's quite popular, with more than 15 million player accounts.

Osu free play no download